Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Peer Group): Non admins can not create new peer groupings #237

Merged
merged 1 commit into from
Sep 28, 2023
Merged

fix(Peer Group): Non admins can not create new peer groupings #237

merged 1 commit into from
Sep 28, 2023

Conversation

geoffreykwan
Copy link
Member

@geoffreykwan geoffreykwan commented Sep 26, 2023 •
edited
Loading

Changes

  • Properly check that the user making the create peer grouping request is authorized
  • When an error occurs, send back an appropriate error message code

Test

  1. Sign in as a teacher that does not have admin privilege
  2. Open the Authoring Tool for a run
  3. Create a Peer Chat step
  4. For Grouping Logic click Select
  5. Click "New Grouping"
  6. Set the "Grouping Name" and "Logic"
  7. Click Create
  8. An error occurs even though you should be able to create a new peer grouping

Closes #236

@geoffreykwan geoffreykwan self-assigned this Sep 26, 2023
@geoffreykwan geoffreykwan mentioned this pull request Sep 26, 2023
Merged
@geoffreykwan geoffreykwan requested a review from breity September 26, 2023 16:18
@geoffreykwan geoffreykwan marked this pull request as ready for review September 26, 2023 16:37
breity
breity approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@geoffreykwan geoffreykwan merged commit 3707067 into develop Sep 28, 2023
2 checks passed
@geoffreykwan geoffreykwan deleted the issue-236-can-not-create-peer-grouping branch September 28, 2023 17:00
@geoffreykwan
Copy link
Member Author

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

breity pushed a commit to I-Sparkle-Germany/I-Sparkle-API that referenced this pull request Jan 10, 2024
@geoffreykwan @breity
fix(Peer Group): Non admins can not create new peer groupings (WISE-C…
caad880 
…ommunity#237)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breity breity breity approved these changes

Assignees

@geoffreykwan geoffreykwan

Labels
released
Projects
WISE Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(Peer Group): Can not create new peer grouping
2 participants
@geoffreykwan @breity